Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tests for filters #2491

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

BiswaViraj
Copy link
Contributor

What change does this PR introduce?

Added the test cases for the Web UI

Why was this change needed?

Other information (Screenshots)

@linear
Copy link

linear bot commented Jan 13, 2023

NV-1429 E2E Tests

@BiswaViraj BiswaViraj self-assigned this Jan 13, 2023
@@ -113,4 +113,70 @@ describe('Workflow Editor - Steps Actions', function () {
cy.clickWorkflowNode(`node-inAppSelector`);
cy.getByTestId(`step-should-stop-on-fail-switch`).should('be.checked');
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if you can add tests for the online filters ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ;)
Added for all the unique filter types on UI

@LetItRock LetItRock self-requested a review January 16, 2023 09:17
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! 🔥

@BiswaViraj BiswaViraj merged commit 1938657 into nv-1441-is-online-filters-feature Jan 16, 2023
@BiswaViraj BiswaViraj deleted the nv-1429-e2e-tests branch January 16, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants