feat: add endpoint to get novu limits #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
approved these changes
Jan 13, 2023
| @@ -164,4 +167,24 @@ export class IntegrationsController { | |||
| }) | |||
| ); | |||
| } | |||
|
|
|||
| @Get('/:channelType/limit') | |||
There was a problem hiding this comment.
Suggested change
| @Get('/:channelType/limit') | |
| @Get('/:channelType/limits') |
As I am not very sure what a limit is, just a briefly reminder if we plan Limit to be a sub-resource with properties to pluralise it.
There was a problem hiding this comment.
After going through all the PR seems it is meant to be a calculated property. So all good. 👌🏻
| export class CalculateLimitNovuIntegration { | ||
| constructor(private messageRepository: MessageRepository) {} | ||
|
|
||
| static MAX_NOVU_INTEGRATION_MAIL_REQUESTS = parseInt(process.env.MAX_NOVU_INTEGRATION_MAIL_REQUESTS || '300', 10); |
There was a problem hiding this comment.
Suggested change
| static MAX_NOVU_INTEGRATION_MAIL_REQUESTS = parseInt(process.env.MAX_NOVU_INTEGRATION_MAIL_REQUESTS || '300', 10); | |
| const DEFAULT_INTEGRATION_LIMIT = 300; | |
| ... | |
| static MAX_NOVU_INTEGRATION_MAIL_REQUESTS = parseInt(process.env.MAX_NOVU_INTEGRATION_MAIL_REQUESTS || DEFAULT_INTEGRATION_LIMIT, 10); |
Also because it looks like we will need it elsewhere (for example tests) so potentially would need to be moved to a configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.