feat(api): add endpoint to set a layout as default #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
commented
Jan 16, 2023
|
|
||
| const BASE_PATH = '/v1/layouts'; | ||
|
|
||
| export const createLayout = async (session: UserSession, name: LayoutName, isDefault: boolean): Promise<LayoutDto> => { |
There was a problem hiding this comment.
Created this helper file as the layout creation functionality is being reused in all the tests.
p-fernandez
commented
Jan 16, 2023
| await this.setIsDefaultForLayout(command.layoutId, command.environmentId, command.organizationId, true); | ||
| } catch (error) { | ||
| Logger.error(error); | ||
| // TODO: Rollback through transactions |
There was a problem hiding this comment.
We have no transactions implementation in the Mongoose adapter repository. Something to do across the stack.
ainouzgali
approved these changes
Jan 17, 2023
p-fernandez
force-pushed
the
nv-1416-set-a-layout-as-default
branch
from
6e3f237
to
2caf6ce
Compare
Done. I had some problems with my environment and had to reinstall dependencies the other day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Adds endpoint and use case to set a layout as default. If there is an existing default layout in the same environment, it will set it to non default while setting as default the chosen one.
Why was this change needed?
The endpoint is probably not going to be used but the use case will be reused in the creation and update endpoints when the
isDefaultproperty is sent as true. As we can only have one default template per environment we need this functionality.Other information (Screenshots)