fix(notification-center-vue): fixed react, react dom dependencies issue #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
@novu/notification-center
@novu/notification-center-vue
labels
LetItRock
commented
Jan 17, 2023
| "react-dom": "^17.0.1" | ||
| }, | ||
| "peerDependencies": { | ||
| "vue": ">=3.0.0" |
There was a problem hiding this comment.
vue should be defined as the peer: #2406
Comment on lines
+25
to
+26
| "react": "^17.0.1", | ||
| "react-dom": "^17.0.1" |
There was a problem hiding this comment.
these should be defined as the direct dependencies, because in the notification-center they are defined as the peer
| @@ -54,6 +54,7 @@ | |||
| "rollup": "^3.7.3", | |||
| "rollup-plugin-gzip": "^3.1.0", | |||
| "rollup-plugin-node-externals": "^5.0.2", | |||
| "rollup-plugin-peer-deps-external": "^2.2.4", | |||
There was a problem hiding this comment.
do not include the peer dependencies in the build
LetItRock
commented
Jan 17, 2023
| "typescript": "~4.7.4", | ||
| "vite": "^4.0.0", | ||
| "vue": "^3.2.45", |
There was a problem hiding this comment.
we have to define it as dev dep for the development
scopsy
approved these changes
Jan 17, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Fixes the issue with not found
react, react-domdependencies.More info: https://discord.com/channels/895029566685462578/1064522952672022559
Why was this change needed?
To fix the above-described issue.
Other information (Screenshots)
Tested in Vue/Vite, Vue CLI, Vue/Quasar apps: