docs: online filter documentation #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1482 Documentation
|
github-actions
bot
added
the
documentation
LetItRock
reviewed
Jan 17, 2023
docs/docs/platform/step-filter.md
Outdated
|
|
||
| The online filter feature can be used to determine if a subscriber is online right now or if the subscriber was online within a specific time period. | ||
|
|
||
| - To determine if a subscriber is online right now, Novu checks the value of the `isOnline` field. If `isOnline` is `true`, the subscriber is online, otherwise the subscriber is offline. |
There was a problem hiding this comment.
", otherwise when the isOnline is false the subscriber is considered offline."
Not sure if we should say that the subscriber might not have these fields set at the beginning, and if not we won't deliver a message, because we don't know whether he is online or not.
There was a problem hiding this comment.
I think once a subscriber is added to the system and it might not have those fields, technically the subscriber should be considered offline, until the subscriber logs in.
There was a problem hiding this comment.
@BiswaViraj I don't think that we can say that, because actually, he could be online at that time, so we don't know. I mean I'm talking about the old ones.
|
Thanks @LetItRock for the suggestions 🚀 |
LetItRock
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Added the documentation for the
online filtersand its working mechanismWhy was this change needed?
Other information (Screenshots)