feat(api): sort and order query params for filtering layouts #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainouzgali
approved these changes
Jan 19, 2023
| ): Promise<LayoutEntity[]> { | ||
| const order = pagination.orderBy ?? OrderDirectionEnum.ASC; | ||
| const sort = pagination.sortBy ? { [pagination.sortBy]: order } : { createdAt: 1 }; |
There was a problem hiding this comment.
Suggested change
| const sort = pagination.sortBy ? { [pagination.sortBy]: order } : { createdAt: 1 }; | |
| const sort = pagination.sortBy ? { [pagination.sortBy]: order } : { createdAt: OrderDirectionEnum.DESC}; |
I think descending makes more sense as a default. So they will get first in the the last one they created. Wdyt?
There was a problem hiding this comment.
Sounds good to me. We might create a task in the feature to add in the list the default first of all.
p-fernandez
force-pushed
the
nv-1491-layouts-filtering-to-support-ordering-by
branch
from
5705b41
to
3a568f7
Compare
p-fernandez
force-pushed
the
nv-1491-layouts-filtering-to-support-ordering-by
branch
from
3a568f7
to
97db630
Compare
p-fernandez
deleted the
nv-1491-layouts-filtering-to-support-ordering-by
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Adds query params and functionality to sort the filtered results by creation date.
Why was this change needed?
UI needs it. And probably users from API.
Other information (Screenshots)