feat(api): disallow delete of assigned #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainouzgali
approved these changes
Jan 19, 2023
| } from '../../../message-template/usecases'; | ||
|
|
||
| @Injectable() | ||
| export class CheckLayoutIsUsedUseCase { |
There was a problem hiding this comment.
I guess we could quite easily use this for the isUsed in the FE table we were planning to scope out 🤭
Maybe we could just do it as a query in the front or as an extra return field to the get-layout-usecase , instead of actually adding a field to the schema. Which I definitely don't like.
Actually might have some value in also making it external API accessible.
There was a problem hiding this comment.
I do agree that the isUsed calculation should be done on demand and not by DB flags that could go out of sync easily. And with the rest of your comments.
| export class FindMessageTemplatesByLayoutUseCase { | ||
| constructor(private messageTemplateRepository: MessageTemplateRepository) {} | ||
|
|
||
| async execute(command: FindMessageTemplatesByLayoutCommand): Promise<MessageTemplateEntity[]> { |
There was a problem hiding this comment.
I really like all these separations. You think ahead💪🏻
I see multiple possible future uses for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Avoids that a layout is deleted if it is being used by a message template.
Why was this change needed?
To avoid data corruption by users actions.
Other information (Screenshots)