refactor: provider card for novu integrations #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidsoderberg
commented
Jan 20, 2023
davidsoderberg
commented
scopsy
approved these changes
Jan 20, 2023
apps/web/src/pages/integrations/components/NovuEmailProviderModal.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/pages/integrations/components/NovuInAppProviderModal.tsx
Outdated
Show resolved
Hide resolved
| export function NovuIntegrationCard({ | ||
| provider, | ||
| onConnectClick = undefined, | ||
| ribbonText = 'Starting provider', |
There was a problem hiding this comment.
Suggested change
| ribbonText = 'Starting provider', | |
| ribbonText = 'Test Provider', |
There was a problem hiding this comment.
I agree with @oba2311 comment "it is unclear whether we are testing it or them" but I also do not like "Free" so my suggestion is to have something else... @p-fernandez any input here?
There was a problem hiding this comment.
Is trail provider better?
There was a problem hiding this comment.
I am not going to make anyone happy: Limited free trial provider. 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.