feat: Added the filter condition component on UI #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1489 Filter condition details list component
In the right section of the Execution Details Modal we would like to show the list with the detailed information about each of the filter conditions. The list item should have:
|
BiswaViraj
commented
Jan 20, 2023
| import { IFilterVariables } from './types'; | ||
|
|
||
| interface ICondition { |
There was a problem hiding this comment.
Moved the interface to shared to able to access it from the UI
BiswaViraj
force-pushed
the
nv-1489-filter-condition-details-list-component
branch
from
541f11d
to
2db0a1f
Compare
|
Will be adding tests in a different PR |
LetItRock
approved these changes
Jan 23, 2023
…hub.com:novuhq/novu into nv-1489-filter-condition-details-list-component
…-condition Nv 1490 e2e tests for the filter condition
BiswaViraj
deleted the
nv-1489-filter-condition-details-list-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)