NV-1541: handle default novu layout #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1541 Handle default novu layout
create default layout per organization + environment. show it in the layouts table. As editable/deletable? if no layout - compile novuDefaultLayout only to editor |
scopsy
commented
Jan 20, 2023
Comment on lines
-23
to
28
| "include": "app/content-templates/usecases/compile-template/templates/layout.handlebars", | ||
| "include": "app/layouts/usecases/get-novu-layout/templates/layout.handlebars", | ||
| "outDir": "dist/src" | ||
| }, | ||
| { | ||
| "include": "app/content-templates/usecases/compile-template/templates/basic.handlebars", | ||
| "include": "app/content-templates/usecases/compile-email-template/templates/basic.handlebars", | ||
| "outDir": "dist/src" |
There was a problem hiding this comment.
Refactored the locaiton of those to live closely to the relevant parts where they belong to
p-fernandez
reviewed
Jan 20, 2023
apps/api/src/app/environments/usecases/create-environment/create-environment.e2e.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/layouts/usecases/get-novu-layout/get-novu-layout.usecase.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/layouts/usecases/set-default-layout/set-default-layout.use-case.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
When creating a new environment add default layout to it.
Why was this change needed?
Closes NV-1541 to make sure new organizations created are created with the default novu layout.
Other information (Screenshots)