Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ask for SNS Region #2568

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

JoeyEamigh
Copy link
Contributor

What change does this PR introduce?

This PR adds AWS region to the SNS configuration.

Why was this change needed?

Closes #2567

Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@ghost
Copy link

ghost commented Jan 27, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@p-fernandez p-fernandez merged commit 80a8611 into novuhq:next Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-1560] 🐛 Bug Report: AWS SNS Provider Errors Out Asking for Region
2 participants