Reply callbacks #2571
Merged
Reply callbacks #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apps/web/src/pages/templates/workflow/WorkflowEditorPage.tsx
# Conflicts: # apps/api/src/app/integrations/usecases/get-novu-integration/get-novu-integration.usecase.ts # pnpm-lock.yaml
…or-reply-callbacks feat: add reply callback step controller
…or-reply-callbacks feat(wip): add reply callback support
Reply callbacks wip
github-actions
bot
added
@novu/api
@novu/dal
@novu/shared
@novu/web
@novu/webhook
providers
labels
# Conflicts: # pnpm-lock.yaml
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
scopsy
reviewed
Jan 23, 2023
apps/api/src/app/environments/dtos/update-environment-request.dto.ts
Outdated
Show resolved
Hide resolved
djabarovgeorge
commented
Jan 23, 2023
Comment on lines
+113
to
+117
| description={ | ||
| 'In order to ensure proper routing and delivery of correspondence, we kindly request that you ' + | ||
| 'provide us with your domain. Once received, it will be added to our whitelist and the email will ' + | ||
| 'be directed to our mail server accordingly.' | ||
| } |
djabarovgeorge
commented
Jan 23, 2023
Comment on lines
+134
to
+136
| This is an optional step, but configuring an MX record with your domain host to direct mail to our server with a | ||
| priority of 10 will ensure that the subscriber sees your domain in the 'reply-to' field of their email client | ||
| instead of Novu's default. |
# Conflicts: # apps/api/src/app/events/usecases/send-message/send-message-chat.usecase.ts # apps/api/src/app/events/usecases/send-message/send-message-email.usecase.ts # apps/api/src/app/events/usecases/send-message/send-message-sms.usecase.ts # apps/web/src/pages/settings/SettingsPage.tsx
scopsy
reviewed
Jan 24, 2023
Comment on lines
12
to
16
| - 'package.json' | ||
| - 'yarn.lock' | ||
| - 'apps/api/**' | ||
| - 'libs/dal/**' | ||
| - 'libs/shared/**' |
There was a problem hiding this comment.
Suggested change
| - 'package.json' | |
| - 'yarn.lock' | |
| - 'apps/api/**' | |
| - 'libs/dal/**' | |
| - 'libs/shared/**' | |
| - 'package.json' | |
| - 'pnpm-lock.yaml' | |
| - 'apps/inbound-mail/**' | |
| - 'libs/dal/**' | |
| - 'libs/shared/**' | |
| - 'libs/testing/**' |
| - name: Terraform setup | ||
| uses: hashicorp/setup-terraform@v1 | ||
| with: | ||
| cli_config_credentials_token: ${{ secrets.TF_INBOUND_MAIL_TOKEN }} |
There was a problem hiding this comment.
Suggested change
| cli_config_credentials_token: ${{ secrets.TF_INBOUND_MAIL_TOKEN }} | |
| cli_config_credentials_token: ${{ secrets.TF_API_TOKEN }} |
This should still be like this
scopsy
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Stacked PRs of reply callbacks feature, containing all the UI steps and email setting design, and back-end logic as well.
Why was this change needed?
Other information (Screenshots)