fix: ensure one default layout in set as default #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1563 Set as default - does not ensure 1 default
In update/create layout, because the db create/update of the new default happens before the SetDefaultLayoutUseCase, there are two at time. It is inconsistent which of them SetDefaultLayoutUseCase finds → so causes a state of two defaults at the same time. |
p-fernandez
approved these changes
Jan 23, 2023
| @@ -10,9 +10,13 @@ export class SetDefaultLayoutUseCase { | |||
| constructor(private layoutRepository: LayoutRepository) {} | |||
|
|
|||
| async execute(command: SetDefaultLayoutCommand) { | |||
| const defaultLayoutId = await this.findDefaultLayoutId(command.environmentId, command.organizationId); | |||
| const defaultLayoutId = await this.findExistingDefaultLayoutId( | |||
There was a problem hiding this comment.
Suggested change
| const defaultLayoutId = await this.findExistingDefaultLayoutId( | |
| const existingDefaultLayoutId = await this.findExistingDefaultLayoutId( |
…s-default-does-not-ensure-1-default # Conflicts: # apps/api/src/app/layouts/usecases/set-default-layout/set-default-layout.use-case.ts
ainouzgali
deleted the
nv-1563-set-as-default-does-not-ensure-1-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
In update/create layout, because the db create/update of the new default happens before the SetDefaultLayoutUseCase, there are two at time. It is inconsistent which of them SetDefaultLayoutUseCase finds → so causes a state of two defaults at the same time.
Why was this change needed?
Other information (Screenshots)