Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 1579 useintercom must be inside #2599

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Conversation

BiswaViraj
Copy link
Contributor

What change does this PR introduce?

Refactored the GotAQuestionButton component to not throw error when INTERCOM_APP_ID & IntercomProvider is unavailable

Why was this change needed?

Other information (Screenshots)

@linear
Copy link

linear bot commented Jan 25, 2023

NV-1579 `useIntercom` must be inside `IntercomProvider`

image.png

Reproduction steps:

  • Open any notification workflow template
  • Click on Test Workflow button at top.

@BiswaViraj BiswaViraj force-pushed the nv-1579-useintercom-must-be-inside branch from 5bef654 to ef11db5 Compare January 25, 2023 08:10
@ghost
Copy link

ghost commented Jan 25, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good@

@BiswaViraj BiswaViraj merged commit bd623f0 into next Jan 25, 2023
@BiswaViraj BiswaViraj deleted the nv-1579-useintercom-must-be-inside branch January 25, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants