Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: populate susbcriber in notification feed #2633

Merged

Conversation

mocherfaoui
Copy link
Contributor

What change does this PR introduce?

populate the subscriber in notification center

Why was this change needed?

closes #2404

@ghost
Copy link

ghost commented Jan 28, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@jainpawan21
Copy link
Member

@mocherfaoui
You will need to change respective DTO also

@mocherfaoui
Copy link
Contributor Author

@jainpawan21
are you referring to this file?

subscriber?: SubscriberResponseDto;

@jainpawan21
Copy link
Member

Yes

@mocherfaoui
Copy link
Contributor Author

@jainpawan21
I think it doesn't need any change since it already includes subscriber ? correct me if I'm wrong.

Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thank you for the contribution! 🚀
I'll give the approval if you will include the e2e test for the new subscriber field.

@scopsy scopsy merged commit d7fa91b into novuhq:next Feb 9, 2023
@mocherfaoui mocherfaoui deleted the populate-subscriber-notifications-feed branch February 9, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-1524] 🚀 Feature: reference of the subscribers data in the notification
4 participants