Updating Cypress from version 12.1.0 to 12.3.0

[RobertoCassino]

What change does this PR introduce?

This PR updates the cypress at apps/web/package.json (line 129) from version 12.1.0 to version 12.3.0.

Why was this change needed?

4 CVEs were found in novu, the version of the Cypress testing framework is the root cause here, as the version used is 12.1.0 and it includes and old version of the packages like simple-git and others.

[ghost]

👇 Click on the image for a new way to code review

• Make big changes easier — review code in small groups of related files

• Know where to start — see the whole change at a glance

• Take a code tour — explore the change with an interactive tour

• Make comments and review — all fully sync’ed with github

  Try it now!

Legend

[p-fernandez]

Mind you to update it also in /apps/widget so we have the versions used in both apps aligned?

[scopsy]

Let's see of tests will pass, last time i tried updating widget it didn't worked out :( Two major versions upgrade, been a few breaking changes there since

[p-fernandez]

Suggested change

	"cypress": "12.3.0",
	"cypress": "^12.3.0",

So we both get it updated (web and widget) and just one single version in the dependency all the time.

[p-fernandez]

🌟

[RobertoCassino]

🌟

Thanks @p-fernandez for approval, the end to end test for widget is still failing and I am not sure what the problem is for the api migration. We focused on replacing .should() with .then() in accordance to the manual provided by Cypress https://docs.cypress.io/guides/references/migration-guide#should. The test is now failing at getNotifications() on line 161 in apps/widget/cypress/e2e/shell-embed.spec.ts. This is weird, as the function is being used in multiple tests which are passing successfully.

The exact point of failure is on line 167 where is trying to execute cy.wrap(body).find([data-test-id="notification-list-item"]);. What would the next steps be?

[p-fernandez]

🌟

Thanks @p-fernandez for approval, the end to end test for widget is still failing and I am not sure what the problem is for the api migration. We focused on replacing .should() with .then() in accordance to the manual provided by Cypress https://docs.cypress.io/guides/references/migration-guide#should. The test is now failing at getNotifications() on line 161 in apps/widget/cypress/e2e/shell-embed.spec.ts. This is weird, as the function is being used in multiple tests which are passing successfully.

The exact point of failure is on line 167 where is trying to execute cy.wrap(body).find([data-test-id="notification-list-item"]);. What would the next steps be?

We might need to revisit the test. Just double checking it is not a timeout issue from Cypress.

[LetItRock]

@RobertoCassino I've fixed failing widget tests, hope they will pass now ;)

[LetItRock]

@RobertoCassino @p-fernandez @scopsy
I see that the test is failing because of the race conditions in the cache, I'll inform @djabarovgeorge

[scopsy]

@LetItRock seems like it's a flaky tests that also happens regardless of this PR. My suggestion is to merge this one and deal with the race condition in another PR. WDYT?

[pieterge]

Crazy question: When would the next release be? Do you guys have a default cycle?

[scopsy]

@pieterge end of the month are the usual monthly cadence, however I plan to release a hotfix release until the end of the week 🙏