Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: so no global style are applied #2670

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

davidsoderberg
Copy link
Contributor

What change does this PR introduce?

Removing the usage of normalize css for our notification center

Why was this change needed?

So the normalize css are not applied to our users websites

Other information (Screenshots)

Screenshot 2023-02-02 at 14 15 09

Screenshot 2023-02-02 at 14 15 15

Screenshot 2023-02-02 at 14 15 22

Screenshot 2023-02-02 at 14 15 31

Screenshot 2023-02-02 at 14 15 47

Screenshot 2023-02-02 at 14 15 54

@linear
Copy link

linear bot commented Feb 2, 2023

NV-1513 🐛 Bug Report: Notification-center adds a lot of unwanted global styles when open

📜 Description

Some global reset styles are added into when the notification center is open. This is messing up with my app css.

👟 Reproduction steps

  1. Add the notification-center to any react project;
  2. open in and inspect head style tags

👍 Expected behavior

Styling to be encapsulated and not adding any global styles to the dom;

👎 Actual Behavior with Screenshots

🤖 Node Version

18

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

@ghost
Copy link

ghost commented Feb 2, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@davidsoderberg davidsoderberg merged commit aa85a07 into next Feb 2, 2023
@davidsoderberg davidsoderberg deleted the nv-1513-bug-report-notification-center-adds-a branch February 2, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants