fix: size of email content "too large" #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1580 Unable to send email if email content size is large
When email content is large, trigger fails with error One workaround is to use minified content, but it is not always a good solution. Expectation:- Size limit should be increased and exact value should be mentioned in docs. |
👇 Click on the image for a new way to code review
Legend |
scopsy
reviewed
Feb 6, 2023
Comment on lines
+72
to
+73
| app.use(extendedBodySizeRoutes, bodyParser.json({ limit: '20mb' })); | ||
| app.use(extendedBodySizeRoutes, bodyParser.urlencoded({ limit: '20mb', extended: true })); |
There was a problem hiding this comment.
Just to double check, is this syntax allowed in nestjs? Not sure I have seen it elsewhere
There was a problem hiding this comment.
You mean the array of routes?
There was a problem hiding this comment.
It works @scopsy :)
davidsoderberg
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
The 20mb was only applied to event trigger - not for the broadcast, test email or to save and update the email content.
Why was this change needed?
Other information (Screenshots)