fix(web): activity feed tooltip issue #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
commented
Feb 6, 2023
| @@ -154,7 +154,7 @@ function updateToolTipStyles(context, tooltipEl: HTMLElement, tooltipModel) { | |||
|
|
|||
| /* eslint-disable no-param-reassign */ | |||
| tooltipEl.style.opacity = '1'; | |||
| tooltipEl.style.left = `${position.left + window.scrollX + tooltipModel.caretX - tooltipModel.width - 40}px`; | |||
| tooltipEl.style.left = `${position.left + window.scrollX + tooltipModel.caretX - tooltipModel.width - 30}px`; | |||
There was a problem hiding this comment.
I don't know why but this magic number worked before it was 40.
I've tried to calculate it differently with translateX but it was not working.
| @@ -23,6 +22,7 @@ function chartStyles(isTriggerSent: boolean, isDark: boolean) { | |||
| padding: 12px 15px 14px 15px; | |||
| pointer-events: none; | |||
| position: absolute; | |||
| z-index: 1; | |||
There was a problem hiding this comment.
z index issue, tooltip was hidden behind the chart
| @@ -14,7 +14,6 @@ function chartStyles(isTriggerSent: boolean, isDark: boolean) { | |||
| } | |||
|
|
|||
| #chartjs-tooltip { | |||
| width: 190px; | |||
There was a problem hiding this comment.
it looks much better without this constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
The Activity Feed tooltip on the bar was not showing up.
Why was this change needed?
Other information (Screenshots)