Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add onChange and onClick events to components #270

Merged
merged 1 commit into from Feb 17, 2022

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Feb 17, 2022

No description provided.

@linear
Copy link

linear bot commented Feb 17, 2022

RLD-95 Add onChange event for all components

Why?

When connecting the buttons to a form, we need to be able to control the change and click states (click only applicable for buttons).

How?

Adding the onChange and onClick on the respective components.

To respect the browser API for better compatibility with form libraries (react-hooks-form and etc…) we need to wrap the mantine event into:

onChange({ target: { type: 'text' | 'radio' | 'etc..', value: 'the input value'}})

@gitpod-io
Copy link

gitpod-io bot commented Feb 17, 2022

@vercel
Copy link

vercel bot commented Feb 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./docs

🔍 Inspect: https://vercel.com/relayed/docs/EJAZ9vGPJxHSDrDgeG8Nsoun1tPg
✅ Preview: Canceled

storybook – ./

🔍 Inspect: https://vercel.com/relayed/storybook/GvU76MPZPX84Z4oeuvHT6fyHJZQ4
✅ Preview: https://storybook-git-rld-95-add-onchange-event-for-all-d4db25-relayed.vercel.app

@ainouzgali
Copy link
Contributor

Looks pagaz ! 😎

So so excited to start on Notifire the New Look next week!

@scopsy scopsy merged commit 32934e2 into master Feb 17, 2022
@scopsy scopsy deleted the rld-95-add-onchange-event-for-all-components branch February 17, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants