Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: so previous change id is used on delete change for notification template #2713

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

davidsoderberg
Copy link
Contributor

What change does this PR introduce?

Same behaviour as on update notification template

Why was this change needed?

To fix so template is deleted in prod env when using promote all

@linear
Copy link

linear bot commented Feb 9, 2023

NV-1621 🐛 Bug Report: Admin UI not deleting templates in production

📜 Description

When the user promotes development changes to production. All changes are not promoted correctly. There is some mismatch.

👟 Reproduction steps

Create a few notification templates in the development environment
Then promote those changes to production.
After successful promotion, delete one or two templates from development.
Now promote changes again to production.
Deleted templates are still there in prod and non-editable.

👍 Expected behavior

It should delete it

👎 Actual Behavior with Screenshots

💻 Operating system

Windows

🤖 Node Version

12

📃 Provide any additional context for the Bug.

dima fix it by deleting it manually from backend. (if anyone has the same issue)

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test? Or will it be too flaky?

@davidsoderberg
Copy link
Contributor Author

Is it possible to add a test? Or will it be too flaky?

I am looking into this right now 😄

@davidsoderberg davidsoderberg merged commit 0aa5449 into next Feb 9, 2023
@davidsoderberg davidsoderberg deleted the nv-1621-bug-report-admin-ui-not-deleting branch February 9, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants