Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(topic): Replace enum with string for simplified understanding #2750

Merged
merged 1 commit into from Feb 13, 2023

Conversation

unicodeveloper
Copy link
Contributor

@unicodeveloper unicodeveloper commented Feb 13, 2023

What change does this PR introduce?

Updates the Topic docs to do away with enums and simply use strings.

Why was this change needed?

This change is needed to simplify the understanding of developers trying to trigger notifications to topics. Before now, they need to go into the codebase to check the value of the enum. With this change, they can just copy and paste and trigger.

Furthermore, it makes it easy for non-JavaScript/non-Node developers to flow with the topics docs.

Other information (Screenshots)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 13, 2023
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@unicodeveloper unicodeveloper added this pull request to the merge queue Feb 13, 2023
Merged via the queue into next with commit 29c16fc Feb 13, 2023
@unicodeveloper unicodeveloper deleted the unicodeveloper/update-topics-docs branch February 13, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants