feat: make sender name an input field for email card #2769
Conversation
davidsoderberg
requested review from
ainouzgali,
scopsy,
p-fernandez and
djabarovgeorge
NV-1473 Option of from and sender name in template level
As of now, we ask from and Sender Name while user connect email provider in integration store. These values are applied to all templates and all subscribers. There should be an option of overriding these values at template level. Because Each template can be of different type, having different type of email content and for different purpose. |
apps/api/src/app/events/usecases/send-message/send-message-email.usecase.ts
Outdated
Show resolved
Hide resolved
| ...integration, | ||
| credentials: { | ||
| ...integration.credentials, | ||
| senderName: senderName && senderName.length > 0 ? senderName : integration.credentials.senderName, |
There was a problem hiding this comment.
| senderName: senderName && senderName.length > 0 ? senderName : integration.credentials.senderName, | |
| senderName: senderName?.length > 0 ? senderName : integration.credentials.senderName, |
Just saving characteres.
There was a problem hiding this comment.
Doing this typescript compliance about senderName possible being undefined...
There was a problem hiding this comment.
You are right. I missed that for not trying the PR in my local.
apps/api/src/app/notification-template/e2e/create-notification-templates.e2e.ts
Show resolved
Hide resolved
|
@davidsoderberg could you please send a loom/photo of how this new input looks like and behaves? |
|
Sure I am not sure the user will understand what the field is used for... |
|
@davidsoderberg aggree, what if we will add the input title similar to the "Email Layout" one? And remove the Inbox view header and will keep it only the preview tab ? |
Right now we do not have in preview so lets think about that part when we get to it... I was thinking of tooltip instead to save space, what do you think about that? |
|
Maybe we can remove the date now it do not look like an inbox row anymore? |
|
I think it makes much more sense @davidsoderberg, we can have the "date" in the preview section. |
|
@davidsoderberg could you add a tooltip near the Sender Name to say that if empty we will use the one from integration page? |
|
|
What change does this PR introduce?
So sender name can be changed from each email template if needed empty field uses default from integration.