-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hide content of textarea with multiline keys #2816
feat: hide content of textarea with multiline keys #2816
Conversation
NV-1529 🐛 Bug Report: APNS private key is not being parsed correctly
📜 DescriptionIn APNS provider there is a field in order to set the
NOTE: 👟 Reproduction steps
👍 Expected behaviorPush notification should be sent. 👎 Actual Behavior with Screenshots
The format of the key normally is the following:
After setting it in the dashboard like I described above, the /v1/integrations API returns:
It seems that it replaces the 💻 Operating systemMacOS 🤖 Node VersionUsing docker (ghcr.io/novuhq/novu/api:0.9.0) - I think Node 16 📃 Provide any additional context for the Bug.No response 👀 Have you spent some time to check if this bug has been raised before?
🏢 Have you read the Contributing Guidelines?
Are you willing to submit PR?None |
@@ -13,6 +14,10 @@ export function IntegrationInput({ | |||
register: any; | |||
}) { | |||
if (isNeededToHide(credential.key)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can refactor this to have the PasswordInput if statement not here, but rather on the "string" type input 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes lets create a tech debt for this 😄
What change does this PR introduce?
Fix so private key in apns can be multiline