Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): skip e2e tests that are doing github login #2824

Merged
merged 7 commits into from
Feb 19, 2023

Conversation

LetItRock
Copy link
Contributor

What change does this PR introduce?

We should mock the GitHub login request in e2e tests instead of doing real login, because the GH send the email verification code for the new devices.

Why was this change needed?

Other information (Screenshots)

@LetItRock LetItRock self-assigned this Feb 17, 2023
@scopsy scopsy added this pull request to the merge queue Feb 19, 2023
Merged via the queue into next with commit 3490c16 Feb 19, 2023
@scopsy scopsy deleted the skip-gh-login-e2e-tests branch February 19, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants