feat: add analytics event to track usage of provider webhooks #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsoderberg
commented
Feb 19, 2023
| { | ||
| provide: AnalyticsService, | ||
| useFactory: async () => { | ||
| const analyticsService = new AnalyticsService(process.env.SEGMENT_TOKEN); |
There was a problem hiding this comment.
This needs to be added in terraform I guess? @scopsy
| @@ -34,6 +36,17 @@ export class Webhook { | |||
| channel, | |||
| }); | |||
|
|
|||
| const member = await this.memberRepository.getOrganizationAdminAccount(command.organizationId); | |||
There was a problem hiding this comment.
We do not know who created the Webhook so I am using admin account here...
davidsoderberg
requested review from
scopsy,
p-fernandez,
ainouzgali and
djabarovgeorge
davidsoderberg
changed the title
scopsy
approved these changes
Feb 19, 2023
Comment on lines
+62
to
+70
| if (member) { | ||
| this.analyticsService.track('[Webhook] - Provider Webhook events parsed', member._userId, { | ||
| _organization: command.organizationId, | ||
| _environmentId: command.environmentId, | ||
| providerId, | ||
| channel, | ||
| events, | ||
| }); | ||
| } |
There was a problem hiding this comment.
I think actually that this one will be enough (no need to have the top one. wdyt?
There was a problem hiding this comment.
I added both to be able to track if we get more webhooks the we parse...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Two tracking events so we can track how much provider webhooks is used.
Why was this change needed?
To be able to understand usage of our provider webhook feature