Nv 1130 generic error message should point at #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1130 Generic error message should point at specific missing part
This message here should be more clear in regards to what is missing: CleanShot 2022-11-02 at 23.19.142x.png Created via Raycast |
…-message-should-point-at
scopsy
approved these changes
Feb 19, 2023
| @@ -162,6 +162,8 @@ export function FlowEditor({ | |||
| const oldNode = nodes[i + 1] || { position: { x: 0, y: 120 } }; | |||
| const newId = (step._id || step.id) as string; | |||
|
|
|||
| await triggerErrors('steps'); | |||
There was a problem hiding this comment.
Why this one is needed here? It triggers the form validation if i understand correctly?
There was a problem hiding this comment.
This is to get the meaningful errors before the submit of the form. So we would know what are the errors immediately on adding a node @scopsy
|
|
||
| const { watch } = useFormContext(); | ||
| let showErrors = initialErrors; |
There was a problem hiding this comment.
This one sounds like a boolean to me, maybe we can rename this to: formErrorsContent or similar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Show more explicit errors on step node. on update click and on Test workflow.
Why was this change needed?
Other information (Screenshots)
https://www.loom.com/share/dd2fba28845544b48263c64edb1fd432