fix: reset page number on tab switch #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1740 Changes table has page number synced for both `Pending` and `History` tables
Why? (Context)
What?Definition of Done |
BiswaViraj
commented
Feb 20, 2023
| @@ -43,6 +43,7 @@ export function PromoteChangesPage() { | |||
| value: PENDING, | |||
| content: ( | |||
| <ChangesTable | |||
| key={page} | |||
There was a problem hiding this comment.
The page number indicator at the bottom of the page sometimes will be out of sync with the current page number,
Adding a key fixed that issue
scopsy
approved these changes
Feb 20, 2023
BiswaViraj
deleted the
nv-1740-changes-table-has-page-number-synced-for
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)