Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add colorscheme prop for embed #2863

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

BiswaViraj
Copy link
Contributor

What change does this PR introduce?

  • Adds colorScheme option for the embed users
  • Updated the docs to have the colorscheme option

Why was this change needed?

Other information (Screenshots)

@linear
Copy link

linear bot commented Feb 20, 2023

NV-1581 Support of colorScheme option in iframe similar to react component

In iframe, default theme is light and colorScheme option is missing to change this behaviour.

There should be a colorScheme option as in react component

https://docs.novu.co/notification-center/react-components#dark-mode-support

Update the iframe doc also

https://docs.novu.co/notification-center/iframe-embed

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 20, 2023
@BiswaViraj BiswaViraj added this pull request to the merge queue Feb 20, 2023
Merged via the queue into next with commit e0d9a18 Feb 20, 2023
@BiswaViraj BiswaViraj deleted the nv-1581-support-of-colorscheme-option-in-iframe branch February 20, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants