fix(api): update subscriber template preferences with wrong template id #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1752 Sentry - PATCH /v1/subscribers/:subscriberId/preferences/:templateId raises error when the template id is wrong
Reproduction StepsExpected BehaviourShould throw 404 HTTP error that the template is not found |
scopsy
approved these changes
Feb 22, 2023
p-fernandez
reviewed
Feb 22, 2023
| @@ -61,6 +61,28 @@ describe('Update Subscribers preferences - /subscribers/:subscriberId/preference | |||
| } | |||
| }); | |||
|
|
|||
| it('should send a Not Found Request error if template id is wrong', async function () { | |||
LetItRock
deleted the
nv-1752-update-template-preferences-fix-wrong-template-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Fixes the Sentry issue: https://novu-r9.sentry.io/issues/3841226005/?project=6248811&query=is%3Aunresolved&referrer=issue-stream
When the
PATCH /v1/subscribers/:subscriberId/preferences/:templateIdis triggered with wrongtemplateIdthe API breaks with 500 error.Why was this change needed?
Other information (Screenshots)