feat(api): homogenize trigger event use cases and fix tech debt #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
commented
Feb 22, 2023
| @@ -56,7 +54,6 @@ export const USE_CASES = [ | |||
| SendMessageDelay, | |||
| SendTestEmail, | |||
| MapTriggerRecipients, | |||
| MapTriggerRecipientsCommand, | |||
There was a problem hiding this comment.
This was a mistake I introduced time ago.
p-fernandez
commented
Feb 22, 2023
Comment on lines
-40
to
-57
| export class TestSendMessageCommand extends EnvironmentWithUserCommand { | ||
| @IsDefined() | ||
| contentType: 'customHtml' | 'editor'; | ||
| @IsDefined() | ||
| payload: any; // eslint-disable-line @typescript-eslint/no-explicit-any | ||
| @IsDefined() | ||
| @IsString() | ||
| subject: string; | ||
| preheader?: string; | ||
| senderName?: string; | ||
| @IsDefined() | ||
| content: string | IEmailBlock[]; | ||
| @IsDefined() | ||
| to: string | string[]; | ||
| @IsOptional() | ||
| @IsString() | ||
| layoutId?: string | null; | ||
| } |
There was a problem hiding this comment.
Moving to its own file.
p-fernandez
commented
Feb 22, 2023
| @@ -21,7 +23,7 @@ export class SendTestEmail { | |||
| private getDecryptedIntegrationsUsecase: GetDecryptedIntegrations | |||
| ) {} | |||
|
|
|||
| public async execute(command: TestSendMessageCommand) { | |||
| public async execute(command: SendTestEmailCommand) { | |||
There was a problem hiding this comment.
We had a mixing naming style for this use case and command. Homogenised.
p-fernandez
commented
Feb 22, 2023
| @@ -1,5 +1,11 @@ | |||
| import type { BuilderFieldOperator } from './builder.types'; | |||
|
|
|||
| export enum TimeOperatorEnum { | |||
There was a problem hiding this comment.
Added for tighter validation.
We could reuse it in other places we use these time strings. For example, DigestUnitEnum.
p-fernandez
force-pushed
the
feat-api-tech-debt-homogenize-use-cases
branch
from
63819aa
to
3e88330
Compare
p-fernandez
commented
Feb 22, 2023
| @@ -458,7 +460,7 @@ async function findAsync<T>(array: T[], predicate: (t: T) => Promise<boolean>): | |||
| } | |||
|
|
|||
| async function filterAsync<T>(arr: T[], callback: (item: T) => Promise<boolean>): Promise<T[]> { | |||
| const fail = Symbol(); | |||
| const fail = Symbol('Filter Async failure'); | |||
There was a problem hiding this comment.
DeepSource flagged this.
p-fernandez
requested review from
ainouzgali,
BiswaViraj,
davidsoderberg,
djabarovgeorge,
LetItRock and
scopsy
Comment on lines
14
to
15
| preheader?: string; | ||
| senderName?: string; |
There was a problem hiding this comment.
Should we add IsOptional() here?
djabarovgeorge
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Homogenise the Trigger Event module use cases and fixes some tech debt related.
Also moves MessageMatcher to its own location as being an use case and not being used by TriggerEvent usecase.
Why was this change needed?
Tech debt.
Other information (Screenshots)