Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Buildx when building images from forked repositories #2894

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

kylegalbraith
Copy link
Contributor

There is a GitHub limitation that restricts access to secrets when workflows are triggered from repositories that have been forked. This means that the Test API workflow can't build an image because it doesn't have access to the secret that would allow it to authenticate to Depot.

This PR adds the ability to check if the PR is coming from a fork, and if so, it will fall back to local Docker Buildx for the image build. If it is not coming from a fork, the image build will happen on Depot.

Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟
Thank you very much for this contribution. It will help our contributors a lot.

@p-fernandez p-fernandez added this pull request to the merge queue Feb 24, 2023
Merged via the queue into novuhq:next with commit 90b7acf Feb 24, 2023
@kylegalbraith kylegalbraith deleted the buildx-fallback-for-community branch February 24, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants