Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fixed onboarding setup responsive issues #2895

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

LetItRock
Copy link
Contributor

What change does this PR introduce?

Fixed a couple of the responsive issues found on the new Onboarding pages.

Why was this change needed?

Other information (Screenshots)

Screen.Recording.2023-02-24.at.16.19.20.mov
Screen.Recording.2023-02-24.at.16.13.35.mov

Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@scopsy
Copy link
Contributor

scopsy commented Feb 26, 2023

@LetItRock should the target be to "next" branch? Or you have another PR for this?

@LetItRock LetItRock changed the base branch from onboarding-demo-trigger-adjustments to next February 27, 2023 08:31
@LetItRock LetItRock changed the base branch from next to onboarding-demo-trigger-adjustments February 27, 2023 08:31
@LetItRock
Copy link
Contributor Author

@scopsy I went out from George's PR: #2886 but I can rebase

@djabarovgeorge
Copy link
Contributor

Awesome fix I did not notice it while working on it, thanks.
Regarding the brach, I think we can merge it independently to the next branch IMO, they are related but do not overlap in the changes.

@LetItRock LetItRock changed the base branch from onboarding-demo-trigger-adjustments to next February 27, 2023 19:57
@LetItRock LetItRock added this pull request to the merge queue Feb 27, 2023
Merged via the queue into next with commit f03c7fc Feb 27, 2023
@LetItRock LetItRock deleted the onboarding-fix-responsivness branch February 27, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants