[NV-1759] fix(api): fixed remove subscriber from topic functionality #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
commented
Feb 24, 2023
| @@ -135,4 +135,90 @@ describe('Remove subscribers to topic - /topics/:topicKey/subscribers/removal (P | |||
| expect(getResponseTopic.name).to.eql(topicName); | |||
| expect(getResponseTopic.subscribers).to.eql([]); | |||
| }); | |||
|
|
|||
| it('should remove subscriber from only one topic', async () => { | |||
There was a problem hiding this comment.
tests to cover the issue
| @@ -42,7 +42,7 @@ export class TopicSubscribersRepository extends BaseRepository<EnforceEnvironmen | |||
| await this.delete({ | |||
| _environmentId, | |||
| _organizationId, | |||
| key: topicKey, | |||
| topicKey, | |||
LetItRock
changed the title
NV-1759 🐛 Bug Report: Removing a subscriber from a topic removes them from all subscribed topics
📜 DescriptionIf a user is subscribed to a bunch of topics and we remove them from a single topic using 👟 Reproduction steps
👍 Expected behaviorRemoving should only remove the subscriber from the defined topic. 👎 Actual Behavior with ScreenshotsSubscriber is removed from every topic they're subscribed to. 📃 Provide any additional context for the Bug.Discord: https://ptb.discord.com/channels/895029566685462578/1078569121861603389 👀 Have you spent some time to check if this bug has been raised before?
🏢 Have you read the Contributing Guidelines?
Are you willing to submit PR?None |
p-fernandez
approved these changes
Feb 25, 2023
| @@ -42,7 +42,7 @@ export class TopicSubscribersRepository extends BaseRepository<EnforceEnvironmen | |||
| await this.delete({ | |||
| _environmentId, | |||
| _organizationId, | |||
| key: topicKey, | |||
| topicKey, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Fixes the issue: #2902
When the subscriber is added to multiple topics the
POST /topics/:topic_key/subscribers/removalendpoint removes him from all the topics, but should only remove from the exact topic by the:topic_key.Why was this change needed?
Fixes the above issue.
Other information (Screenshots)