[NV-1804] Fix: Allow Distributed Cache to use Redis Password #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am still getting errors in my container built off of this branch about |
|
No longer getting the error after changing the tag on my docker image - seems to have been user error. The pipeline that failed seems to be a docker bug since I did not touch any docker stuff in this commit. Will fast-forward and see if that helps. |
p-fernandez
reviewed
Mar 6, 2023
apps/api/src/app/shared/services/distributed-lock/distributed-lock.service.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/shared/services/distributed-lock/distributed-lock.service.ts
Show resolved
Hide resolved
|
Applied the suggestions - thank y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Supports Redis passwords in the distributed cache system.
Why was this change needed?
Fixes #2941.
Other information (Screenshots)
I just used the same connection object y'all were using for Bull. Figured it was probably closest to what y'all wanted.