Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add digest flow diagram #2949

Merged
merged 5 commits into from
Mar 8, 2023

Conversation

djabarovgeorge
Copy link
Contributor

What change does this PR introduce?

Add digest flow for our preview and playground set-started steps.

Why was this change needed?

Creation of new components, I used react flow in order to get out of the box flow builder of the flow so we will have easy to maintain and add new nodes in the future id need.

Other information (Screenshots)

Image ref (please ignore all the none relevant components):

image

image

@linear
Copy link

linear bot commented Mar 6, 2023


return (
<Wrapper dark={colorScheme === 'dark'}>
<div style={{ minHeight: '500px', height: '100%', width: 'inherit' }}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore the sizing here they will could change in the future, at the moment I only created this part on the main body section.

<Icon style={{ marginRight: '15px' }} />
<Text weight={'bold'}>{data.label} </Text>
</ButtonLeftContent>
{ActionItem ? <ActionItem /> : null}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is a hot placeholder in the action section on the right side on the button I left for the playground stage, @LetItRock you can use it as well, I am still not sure I will need it on my page.

https://www.figma.com/file/hlsUxjq2kxUU7aVBf2QyGu?node-id=409:41745#384032833

import { NodeButton } from './NodeButton';
import { DigestGradient } from '../../../../../design-system/icons/general/DigestGradient';

export function DigestNode({ data, id }: { data: any; id: string }) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LetItRock FYI
Created a separate component for every button so it will be easy to create separate logic for every button (like the trigger button on the playground etc..)
If we see the need to merge them into one generic component we most definitely can :)

Comment on lines +22 to +25
zoomOnScroll={false}
zoomOnPinch={false}
panOnDrag={false}
panOnScroll={false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these props true as default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, added those because i wanted only a preview of the flow and not the full canvas component.

… NV-1806/create-digest-flow

# Conflicts:
#	apps/web/src/design-system/icons/general/DigestGradient.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants