-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): digest workflow playground shell #2961
feat(web): digest workflow playground shell #2961
Conversation
NV-1809 The Digest Workflow Playground shell
In this ticket we want to create the page shell without the Workflow tree component, it will be added later. |
title?: string; | ||
style?: CSSProperties; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow to pass title and style props
import { colors } from '../config'; | ||
import { Text } from '../typography/text/Text'; | ||
|
||
export function ArrowButton({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored props slightly and moved to the design system folder
text-decoration: underline; | ||
`; | ||
|
||
export const TemplatesDigestPlaygroundPage = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the digest workflow playground page
<SubHeading>The digest engine aggregates multiple events into a precise notification</SubHeading> | ||
</Stack> | ||
<Stack mt={40} align="center"> | ||
<DigestWorkflowHolder /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we will insert the workflow tree component later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very slick component building. Great direction. 👏🏻
cy.getByTestId('try-digest-playground-tile').should('not.be.disabled'); | ||
cy.getByTestId('try-digest-playground-tile').click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we can chain the actions. Though I like the readability line by line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we can chain it, will do that ;)
@@ -9,6 +9,7 @@ export enum ROUTES { | |||
PARTNER_INTEGRATIONS_VERCEL_LINK_PROJECTS = '/partner-integrations/vercel/link-projects', | |||
PARTNER_INTEGRATIONS_VERCEL_LINK_PROJECTS_EDIT = '/partner-integrations/vercel/link-projects/edit', | |||
ANY = '/*', | |||
TEMPLATES_DIGEST_PLAYGROUND = '/templates/digest-playground/:templateId', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are carried away because of previous implementations but URL should be: '/templates/:templateId/digest-playground'
to be more REST compliant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure I can do that :)
|
||
return ( | ||
<PageContainer title="Digest Workflow Playground" style={{ padding: '32px' }}> | ||
<ArrowButton label="Go Back" onClick={() => navigate(-1)} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does navigate(-1)
reacts if someone loads the URL directly in the navigator? I am afraid the go back button wouldn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works and navigates to the /templates
page
What change does this PR introduce?
Created the shell for the Digest Workflow Playground page.
Why was this change needed?
This ticket is part of the improvements over the onboarding experience.
Other information (Screenshots)
Screen.Recording.2023-03-07.at.12.10.49.mov