fix: only throw error if response contains any failed data

[BiswaViraj]

What change does this PR introduce?

Closes #2966

Throws error only when the notification fails, and should be able to send success response on notification being delivered successfully

Why was this change needed?

Notifications sent successfully were being marked as failed.

Other information (Screenshots)

[linear]

NV-1817 🐛 Bug Report: APNS delivered notifications marked as failed (v 0.12.0)

📜 Description

We discovered something interesting while testing APNS integration for sending ios push notifications.

When we use a valid token, the notification is being received BUT we get an error (with an empty message) and the transaction is marked as failed.

When we use a wrong token then we get an error with the correct message and the transaction is also being marked as failed.

So, in both cases the transaction is marked as failed but in the first case we actually saw it coming in.

👟 Reproduction steps

1. Setup APNS provider
2. Create subscriber and notification template
3. Send ios PUSH notification to the subscriber's device token

👍 Expected behavior

Message should be received and transaction should be marked as successful.

👎 Actual Behavior with Screenshots

Message is being received but transaction is marked as failed with an empty error.

{
  “stack”: “Error: \n    at APNSPushProvider.<anonymous> (/usr/src/app/providers/apns/build/main/lib/apns.provider.js:84:35)\n    at step (/usr/src/app/providers/apns/build/main/lib/apns.provider.js:44:23)\n    at Object.next (/usr/src/app/providers/apns/build/main/lib/apns.provider.js:25:53)\n    at fulfilled (/usr/src/app/providers/apns/build/main/lib/apns.provider.js:16:58)\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)“,
  “message”: “”
}

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to submit PR?

None

[p-fernandez]

🌟

[p-fernandez]

Reference for this change:
https://github.com/node-apn/node-apn/blob/master/doc/provider.markdown#failed