Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra): when upgrading to pnpm 7.28.0 we didn't update the images #2987

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

p-fernandez
Copy link
Contributor

@p-fernandez p-fernandez commented Mar 9, 2023

What change does this PR introduce?

Homogenise the PNPM version all throughout the monorepo.

Why was this change needed?

PNPM it was upgraded to 7.28.0 (

"packageManager": "pnpm@7.28.0",
) but not in the Docker images and some scripts. This fixes that.
Also it is an investigation step to see why this CI check fails for a dependency update:
https://github.com/novuhq/novu/actions/runs/4373578609/jobs/7651925951

Other information (Screenshots)

Copy link
Contributor

@BiswaViraj BiswaViraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@p-fernandez p-fernandez added this pull request to the merge queue Mar 9, 2023
Merged via the queue into next with commit 1832e1d Mar 9, 2023
@p-fernandez p-fernandez deleted the fix-upgrade-to-pnpm-7.28.0 branch March 9, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants