feat(api): clarify the notification steps creation #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
requested review from
davidsoderberg,
LetItRock,
ainouzgali,
scopsy,
BiswaViraj and
djabarovgeorge
p-fernandez
force-pushed
the
feat-clarify-steps-creation
branch
from
5cd2378
to
d138ad6
Compare
p-fernandez
commented
Mar 10, 2023
| @@ -91,7 +91,10 @@ export class CreateNotificationTemplate { | |||
| shouldStopOnFail: message.shouldStopOnFail, | |||
| replyCallback: message.replyCallback, | |||
| }); | |||
| parentStepId = stepId; | |||
|
|
|||
| if (stepId) { | |||
There was a problem hiding this comment.
Change to comply with setting _id as optional for MessageTemplateEntity.
p-fernandez
commented
Mar 10, 2023
| ChangeEntityTypeEnum.MESSAGE_TEMPLATE, | ||
| item._id | ||
| ); | ||
| if (item._id) { |
There was a problem hiding this comment.
Change to comply with setting _id as optional for MessageTemplateEntity.
p-fernandez
commented
Mar 10, 2023
| @@ -37,7 +37,10 @@ export class CreateMessageTemplate { | |||
| actor: command.actor, | |||
| }); | |||
|
|
|||
| item = (await this.messageTemplateRepository.findById(item._id)) as MessageTemplateEntity; | |||
| if (item?._id) { | |||
There was a problem hiding this comment.
Change to comply with setting _id as optional for MessageTemplateEntity.
p-fernandez
commented
Mar 10, 2023
| @@ -51,7 +51,10 @@ export class PromoteNotificationTemplateChange { | |||
|
|
|||
| return undefined; | |||
| } | |||
| step._templateId = oldMessage._id; | |||
|
|
|||
| if (step?._templateId && oldMessage._id) { | |||
There was a problem hiding this comment.
Change to comply with setting _id as optional for MessageTemplateEntity.
| type: StepTypeEnum.TRIGGER, | ||
| content: '', | ||
| } as MessageTemplateEntity, | ||
| }, |
There was a problem hiding this comment.
Not relevant to this PR but are you aware of why _layoutId is nullable and not optional?
There was a problem hiding this comment.
Retro-compatibility with the existing notificaiton templates after @ainouzgali and me implement the Layouts feature for email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Small refactor to aggregate the logic accordingly.
Why was this change needed?
Inside of the use case that was in charge on deciding if a digest step should be created or not we were doing more things, like filtering the active steps for the notification, adding extra complexity to that use case.
These changes should facilitate the vision if we are committing to decisions on creating or not digest steps before we should.
Other information (Screenshots)