Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job grouping #3011

Merged
merged 35 commits into from
Mar 28, 2023
Merged

Job grouping #3011

merged 35 commits into from
Mar 28, 2023

Conversation

davidsoderberg
Copy link
Contributor

No description provided.

Cliftonz
Cliftonz approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@Cliftonz Cliftonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from my point of view.

@davidsoderberg davidsoderberg marked this pull request as ready for review March 16, 2023 13:31
Cliftonz
Cliftonz approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@Cliftonz Cliftonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidsoderberg davidsoderberg temporarily deployed to Development March 23, 2023 13:08 — with GitHub Actions Inactive
@davidsoderberg davidsoderberg temporarily deployed to Development March 23, 2023 13:08 — with GitHub Actions Inactive
@davidsoderberg davidsoderberg temporarily deployed to Development March 23, 2023 14:46 — with GitHub Actions Inactive
@davidsoderberg davidsoderberg temporarily deployed to Development March 23, 2023 14:46 — with GitHub Actions Inactive
@scopsy
Copy link
Contributor

scopsy commented Mar 27, 2023

@davidsoderberg looks great! It seems like the Test API / build_docker (pull_request) needs to be updated with the appropriate docker tag input to build correctly

@davidsoderberg davidsoderberg added this pull request to the merge queue Mar 28, 2023
Merged via the queue into next with commit 61eb0b5 Mar 28, 2023
@davidsoderberg davidsoderberg deleted the job-grouping branch March 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-fernandez p-fernandez Awaiting requested review from p-fernandez

@LetItRock LetItRock Awaiting requested review from LetItRock

@scopsy scopsy Awaiting requested review from scopsy

@Cliftonz Cliftonz Awaiting requested review from Cliftonz

Assignees
No one assigned
Labels
@novu/api @novu/ws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidsoderberg @scopsy @LetItRock @p-fernandez @Cliftonz