NV-1618 - Add Missing APNS Docs #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1618 Missing APNS docs
We have APNs provider in Push Channel but its documentation page is missing |
unicodeveloper
requested review from
jainpawan21 and
p-fernandez
and removed request for
jainpawan21
github-actions
bot
added
the
documentation
p-fernandez
approved these changes
Mar 15, 2023
docs/docs/channels/push/fcm.md
Outdated
| ```ts | ||
| import { Novu } from '@novu/node'; | ||
| import { Novu } from '@node'; |
There was a problem hiding this comment.
Suggested change
| import { Novu } from '@node'; | |
| import { Novu } from '@novu/node'; |
Please rollback the change.
There was a problem hiding this comment.
Thanks, will do
docs/docs/channels/push/fcm.md
Outdated
| Before triggering the notification to a subscriber(user) with push as a step in the workflow, make sure you have added the subscriber's device token as follows: | ||
|
|
||
| ```ts | ||
| import { Novu, PushProviderIdEnum } from '@novu/node'; | ||
| import { Novu, PushProviderIdEnum } from '@node'; |
There was a problem hiding this comment.
And here too. 🙂
Suggested change
| import { Novu, PushProviderIdEnum } from '@node'; | |
| import { Novu, PushProviderIdEnum } from '@novu/node'; |
There was a problem hiding this comment.
thanks for catching
jainpawan21
requested changes
Mar 15, 2023
| 'loc-key' : 'GAME_PLAY_REQUEST_FORMAT', | ||
| 'loc-args' : [ 'Shelly', 'Rick'] | ||
| }, | ||
| sound: 'demo.wav' |
There was a problem hiding this comment.
Is demo.wav an attachment or some static name?
There was a problem hiding this comment.
a static name, it can be any thing
docs/docs/channels/push/apns.md
Outdated
|
|
||
| const novu = new Novu(process.env.NOVU_API_KEY); | ||
|
|
||
| const body = req.body; // From your HTTPS listener |
There was a problem hiding this comment.
this line can be removed as body is not used in setCredentials
There was a problem hiding this comment.
Oh makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This adds the docs to help activate and integrate apns. It also improves the firebase set up documentation.
Why was this change needed?
Docs is non-existent.
Other information (Screenshots)