feat(web): getting started dots navigation and footer button logic #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
commented
Mar 17, 2023
| import { errorMessage } from '../../../utils/notifications'; | ||
| import { useNotificationGroup } from '../../../hooks'; | ||
|
|
||
| export const useCreateDigestDemoWorkflow = () => { |
There was a problem hiding this comment.
moved the code to reusable hook, used on the getting started page and on the templates placeholder
| }, | ||
| '100%': { | ||
| boxShadow: '0 0 0 0 rgba(255, 82, 82, 0)', | ||
| [`&:not(:disabled):not([data-loading])`]: { |
There was a problem hiding this comment.
do not show the pulse animation if button is loading or disabled
| @@ -18,6 +18,7 @@ interface IInputProps extends SpacingProps { | |||
| min?: string | number; | |||
| max?: string | number; | |||
| onBlur?: (event: FocusEvent<HTMLInputElement>) => void; | |||
| autoFocus?: boolean; | |||
There was a problem hiding this comment.
added autoFocus prop to input
| </Grid> | ||
| <LeftSide>{leftSide}</LeftSide> | ||
| <MiddleSide> | ||
| <DotsNavigation selectedIndex={selectedIndex} size={2} onClick={handleOnNavigationClick} /> |
There was a problem hiding this comment.
the getting started page footer dots navigation
| @@ -28,21 +42,21 @@ export function GetStarted() { | |||
| leftSide: <LearnMoreRef />, | |||
| rightSide: ( | |||
| <NavButton navigateTo={getStartedSteps.second} variant={'gradient'}> | |||
| <div style={{ fontSize: '16px' }}>Next Page</div> | |||
| <div style={{ fontSize: '16px' }}>Next</div> | |||
There was a problem hiding this comment.
it's super tight on the smaller screens so I've changed the text to be smaller
LetItRock
commented
Mar 17, 2023
| @@ -76,7 +76,7 @@ export function SideNav({}: Props) { | |||
|
|
|||
| const menuItems = [ | |||
| { | |||
| condition: !readonly && currentUser?.showOnBoarding, | |||
| condition: !readonly, | |||
There was a problem hiding this comment.
getting started page navigation item will be always visible (that's what Nikolay wanted)
LetItRock
commented
Mar 17, 2023
Comment on lines
+29
to
+32
| let isIntegrationActive = !!integrations?.some((integration) => integration.channel === channel.type); | ||
| if (channel.type === ChannelTypeEnum.EMAIL) { | ||
| isIntegrationActive = isIntegrationActive || !isLimitReached; | ||
| } |
There was a problem hiding this comment.
the logic to show the "active" label near to the channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Getting Started page:
Why was this change needed?
Other information (Screenshots)
Screen.Recording.2023-03-17.at.14.13.52.mov