Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style : onboarding paddings and centering #3044

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

ainouzgali
Copy link
Contributor

What change does this PR introduce?

Why was this change needed?

Other information (Screenshots)

@ainouzgali ainouzgali changed the title Style fix paddings onboarding Style : onboarding paddings and centering Mar 19, 2023
@@ -51,6 +50,7 @@ export function DigestDemoFlow({
zoomOnPinch={false}
panOnDrag={false}
panOnScroll={false}
preventScrolling={false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good left one commant :)

Comment on lines 45 to 46
position: absolute;
left: 55%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so sure about this part 🤔

@djabarovgeorge
Copy link
Contributor

Added a small suggestion, with a switch to Grid Col.
Let me know if you see it fit there.

@ainouzgali ainouzgali added this pull request to the merge queue Mar 20, 2023
@ainouzgali ainouzgali merged commit 8b4ec11 into next Mar 20, 2023
@ainouzgali ainouzgali deleted the style-fix-paddings-onboarding branch March 20, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants