feat(web): integrations store modal analytics #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
approved these changes
Mar 21, 2023
| @@ -0,0 +1,6 @@ | |||
| export enum IntegrationsStoreModalAnalytics { | |||
| CREATE_INTEGRATION_FORM_SUBMIT = '[Integrations Store Modal] Create Integration Form Submit', | |||
There was a problem hiding this comment.
Suggested change
| CREATE_INTEGRATION_FORM_SUBMIT = '[Integrations Store Modal] Create Integration Form Submit', | |
| CREATE_INTEGRATION_FORM_SUBMIT = 'Create Integration Form Submit - [Integrations Store Modal]', |
A small suggestion is to move the category to the end. It's just easier to read on mixpanel because their events dropdown are quite small, so you would only read the repeated beginning :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Integration Store Modal - segment analytics.
Why was this change needed?
Other information (Screenshots)