feat(notification-center-vue): use the novu forked floating-vue library #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
The
notification-center-vuepackage has a dependency on the forkedfloating-vuelibrary, which has an important fix applied. The original library is not maintained.The quick fix for use before was to as the link to a GH resource (tarball) in the dependencies list. But, this solution is not working well everywhere, for ex. some Indian ISPs are blocking downloads from the GH, resulting in the failed installation of the
notification-center-vuepackage.Now, we've forked the
floating-vuelibrary under the Novu org and released it on the NPM, so we can now install it normally through the NPM registry. And this PR is using that NPM package.Why was this change needed?
Context: https://discord.com/channels/895029566685462578/1083589887804067880
Other information (Screenshots)
Screen.Recording.2023-03-20.at.17.58.31.mov