Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Node client bulk trigger #3066

Merged
merged 3 commits into from
Mar 27, 2023
Merged

fix: Node client bulk trigger #3066

merged 3 commits into from
Mar 27, 2023

Conversation

szbartnik
Copy link
Contributor

What change does this PR introduce?

Fixes Node client's bulkTrigger operation.

Why was this change needed?

Node client's bulkTrigger is throwing an error:

TypeError: novu.bulkTrigger is not a function

Other information (Screenshots)

Temporary workaround I'm using:

novuClient.events.bulkTrigger

scopsy
scopsy approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thank you!

@scopsy scopsy added this pull request to the merge queue Mar 27, 2023
Merged via the queue into novuhq:next with commit ab351f1 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopsy scopsy scopsy approved these changes

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szbartnik @scopsy @LetItRock