Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing authmodule import in layout module #3077

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

jainpawan21
Copy link
Member

What change does this PR introduce?

  1. Add AuthModule import in LayoutModule [suggested by @ainouzgali ]
  2. Add @UseGuards(JwtAuthGuard) in layouts controller apis

Why was this change needed?

Layouts APIs are not accessible using api key. Only accessible with bearer token

Other information (Screenshots)

@scopsy
Copy link
Contributor

scopsy commented Mar 26, 2023

@jainpawan21 i'm not sure this is needed due to @UseGuards(JwtAuthGuard) is located on the controller level and is applied to each controller endpoint. This pattern exists in a lot of our controller.

@jainpawan21
Copy link
Member Author

@jainpawan21 i'm not sure this is needed due to @UseGuards(JwtAuthGuard) is located on the controller level and is applied to each controller endpoint. This pattern exists in a lot of our controller.

Did not notice that we are using this guard at controller level. Removed from route level ✅

Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@ainouzgali ainouzgali added this pull request to the merge queue Mar 27, 2023
Merged via the queue into next with commit 969316a Mar 27, 2023
@ainouzgali ainouzgali deleted the fix/add-missing-authmodule-in-layout-module branch March 27, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants