feat: add mark message action as seen dto #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1180 Swagger is missing the body of /messages/actions/:type
the swagger annotations is missing the body of the request inside our API reference: https://docs.novu.co/api/mark-message-action-as-seen/ The missing is the body with |
p-fernandez
reviewed
Mar 27, 2023
Comment on lines
17
to
19
| @IsOptional() | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| payload: any; |
There was a problem hiding this comment.
Considering that payload is saved as Mixed type in the database, I think we can safely replace the any for a Record<string, unknown> and thus only allow JavaScript object structures.
scopsy
approved these changes
Apr 3, 2023
| description: 'Message action payload', | ||
| }) | ||
| @IsOptional() | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
I think this can be removed now
p-fernandez
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Add
MarkMessageActionAsSeenDtoWhy was this change needed?
Fixes NV-1180
Other information (Screenshots)