fix: upgrade bullmq versions #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
commented
Mar 29, 2023
| return { | ||
| ...this.bullConfig, | ||
| lockDuration: 90000, | ||
| concurrency: 200, | ||
| settings: { | ||
| backoffStrategies: this.getBackoffStrategies(), | ||
| backoffStrategy: this.getBackoffStrategies(), |
There was a problem hiding this comment.
Was refactored to a function instead of object since version 2
scopsy
commented
Mar 29, 2023
Comment on lines
-69
to
-74
| public createScheduler(name: string, config: QueueBaseOptions) { | ||
| this._queueScheduler = new QueueScheduler(name, config); | ||
|
|
||
| return this._queueScheduler; | ||
| } | ||
|
|
There was a problem hiding this comment.
Scheduler is not needed because it is now taken care of by the Worker class
p-fernandez
approved these changes
Mar 29, 2023
| @@ -214,24 +209,18 @@ export class WorkflowQueueService { | |||
| } | |||
|
|
|||
| private getBackoffStrategies = () => { | |||
| return { | |||
| [BackoffStrategiesEnum.WEBHOOK_FILTER_BACKOFF]: async ( | |||
There was a problem hiding this comment.
The enum is not needed now then. 🙂
There was a problem hiding this comment.
We still use it to specify when adding the actual job, it is accessed in the "Type" param. For now we only have one type, but might expand it in the future so will leave this for now
…into align-bullmq-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
We have mismatched version between the difference services. Updated all versions to be the same.